Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use osixia/openldap:1.5.0 and ldaps://xxx #20731

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use osixia/openldap:1.5.0 and ldaps://xxx #20731

wants to merge 1 commit into from

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 11, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@zyyw zyyw added the release-note/update Update or Fix label Jul 11, 2024
@zyyw zyyw requested a review from a team as a code owner July 11, 2024 11:35
@zyyw zyyw added release-note/infra Infra related changes e.g. release, test, ship etc... and removed release-note/update Update or Fix labels Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.25%. Comparing base (c8c11b4) to head (12583ad).
Report is 275 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20731       +/-   ##
===========================================
+ Coverage   45.36%   66.25%   +20.88%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113501   +100168     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75195    +69146     
- Misses       6983    34194    +27211     
- Partials      301     4112     +3811
Flag Coverage Δ
unittests 66.25% <ø> (+20.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

chlins
chlins approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

wy65701436
wy65701436 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions GitHub Actions
Copy link

This PR is being marked stale due to a period of inactivty. If this PR is still relevant, please comment or remove the stale label. Otherwise, this PR will close in 30 days.

@github-actions github-actions bot added Stale and removed Stale labels Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wy65701436 wy65701436 wy65701436 approved these changes

@chlins chlins chlins approved these changes

Assignees

@wy65701436 wy65701436

@OrlinVasilev OrlinVasilev

@MinerYang MinerYang

Labels
release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zyyw @wy65701436 @chlins @OrlinVasilev @MinerYang